Skip to content

Allow usage of grant and role when not managing postgresql::server #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Conversation

tuxmea
Copy link
Contributor

@tuxmea tuxmea commented Mar 30, 2020

Some installations use other ways to install postgresql.
But people still want to make use of grant and role defined type.

This PR moves all variables with default values set to postgresql::server::<var> into the defined types parameter list.
A spec test was added to ensure that postgresql::server class is not part of the catalog.

@tuxmea tuxmea requested a review from a team as a code owner March 30, 2020 12:02
@puppet-community-rangefinder
Copy link

postgresql::server::grant is a type

The enclosing module is declared in 50 of 578 indexed public Puppetfiles.

Breaking changes to this file WILL impact these modules (exact match):

postgresql::server::role is a type

The enclosing module is declared in 50 of 578 indexed public Puppetfiles.

Breaking changes to this file WILL impact these modules (exact match):

Breaking changes to this file MAY impact these modules (near match):


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Some installations use other ways to install postgresql.
But people still want to make use of grant and role defined type
@carabasdaniel
Copy link
Contributor

Hi @tuxmea,

Thank you for your contribution.

@carabasdaniel carabasdaniel merged commit 6ee4305 into puppetlabs:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants